Adopt TRG 1-03 and 2-03 concerning already in use practices to fulfill the intention #1414
Conversation
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
lgblaumeiser
requested review from
matbmoser,
mgarciaLKS,
stephanbcbauer and
tom-rm-meyer-ISST
stephanbcbauer
left a comment
stephanbcbauer
left a comment
There was a problem hiding this comment.
LGTM, thx @lgblaumeiser just a typo and a question from my side. I think we should get more reviews on TRGs "changes"?
Co-authored-by: Stephan Bauer <[email protected]>
Added guidance on using GitHub release notes for documenting changes.
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| DEPENDENCIES | ||
| LICENSE | ||
| NOTICE.md |
There was a problem hiding this comment.
Did we decide that these files are NOT a must? Do we have, somewhere else documented, what kind of structure we expect? Just thinking loud, because we also check these files in the automatic release checks https://eclipse-tractusx.github.io/sig-release/
There was a problem hiding this comment.
You find that in the description of the PR, the point is, that these files are mentioned with a reason in TRG 7.01, there was already a mismatch between the two TRGs, so my proposal is, to get rid of the redundancy and require these files in the TRG that motivates them.
There was a problem hiding this comment.
thx. Wer lesen kann ist klar im Vorteil :)
|
@eclipse-tractusx/automotive-tractusx-committers would be nice to get more reviews, especially on TRG changes ;) thanks |
Description
TRG 1-03
TRG 2-03
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
Closes #1412
Closes #1413